diff --git a/src/main/java/com/drtshock/playervaults/PlayerVaults.java b/src/main/java/com/drtshock/playervaults/PlayerVaults.java index 1b53bde..c26cb6f 100644 --- a/src/main/java/com/drtshock/playervaults/PlayerVaults.java +++ b/src/main/java/com/drtshock/playervaults/PlayerVaults.java @@ -91,10 +91,10 @@ public class PlayerVaults extends JavaPlugin { private String _versionString; private int maxVaultAmountPermTest; private Metrics metrics; - private Config config = new Config(); + private final Config config = new Config(); private BukkitAudiences platform; - private Translation translation = new Translation(this); - private List exceptions = new CopyOnWriteArrayList<>(); + private final Translation translation = new Translation(this); + private final List exceptions = new CopyOnWriteArrayList<>(); public static PlayerVaults getInstance() { return instance; @@ -452,7 +452,7 @@ public class PlayerVaults extends JavaPlugin { * Get the legacy UUID vault data folder. * Deprecated in favor of base64 data. * - * @return + * @return uuid folder */ @Deprecated public File getUuidData() { diff --git a/src/main/java/com/drtshock/playervaults/config/Loader.java b/src/main/java/com/drtshock/playervaults/config/Loader.java index d025ee0..0dd9759 100644 --- a/src/main/java/com/drtshock/playervaults/config/Loader.java +++ b/src/main/java/com/drtshock/playervaults/config/Loader.java @@ -76,7 +76,7 @@ public class Loader { return Loader.loadNode(config, configObject); } - private static Set> types = new HashSet<>(); + private static final Set> types = new HashSet<>(); static { Loader.types.add(Boolean.TYPE); diff --git a/src/main/java/com/drtshock/playervaults/config/file/Config.java b/src/main/java/com/drtshock/playervaults/config/file/Config.java index b8a60b3..71d8f23 100644 --- a/src/main/java/com/drtshock/playervaults/config/file/Config.java +++ b/src/main/java/com/drtshock/playervaults/config/file/Config.java @@ -25,7 +25,7 @@ import java.util.Collections; import java.util.List; import java.util.logging.Logger; -@SuppressWarnings({"FieldCanBeLocal", "InnerClassMayBeStatic", "unused"}) +@SuppressWarnings({"FieldMayBeFinal", "FieldCanBeLocal", "InnerClassMayBeStatic", "unused"}) public class Config { public class Block { private boolean enabled = true; diff --git a/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultHolder.java b/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultHolder.java index 8bf8e1e..651335d 100644 --- a/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultHolder.java +++ b/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultHolder.java @@ -27,7 +27,7 @@ import org.bukkit.inventory.InventoryHolder; public class VaultHolder implements InventoryHolder { private Inventory inventory; - private int vaultNumber; + private final int vaultNumber; /** * Creates a new vault holder diff --git a/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultManager.java b/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultManager.java index 1bec04c..6428a78 100644 --- a/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultManager.java +++ b/src/main/java/com/drtshock/playervaults/vaultmanagement/VaultManager.java @@ -220,7 +220,7 @@ public class VaultManager { /** * Gets the numbers belonging to all their vaults. * - * @param holder + * @param holder holder * @return a set of Integers, which are player's vaults' numbers (fuck grammar). */ public Set getVaultNumbers(String holder) { @@ -326,7 +326,6 @@ public class VaultManager { * Attempt to delete a vault file. * * @param holder UUID of the holder. - * @return true if successful, otherwise false. */ public void deletePlayerVaultFile(String holder) { File file = new File(this.directory, holder + ".yml");