From 598962592bb4ea20c0cb77919378b9426235d91e Mon Sep 17 00:00:00 2001 From: okx-code Date: Mon, 20 Jul 2020 19:55:37 +0100 Subject: [PATCH] fix advancement requiremnt --- build.gradle | 1 - .../requirement/AdvancementRequirement.java | 13 +++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/build.gradle b/build.gradle index 1aed2e5..3a7bbcd 100644 --- a/build.gradle +++ b/build.gradle @@ -8,7 +8,6 @@ version '3.9' repositories { mavenCentral() - mavenLocal() maven { url 'https://hub.spigotmc.org/nexus/content/groups/public/' } diff --git a/src/main/java/sh/okx/rankup/requirements/requirement/AdvancementRequirement.java b/src/main/java/sh/okx/rankup/requirements/requirement/AdvancementRequirement.java index aa352c3..ad75b90 100644 --- a/src/main/java/sh/okx/rankup/requirements/requirement/AdvancementRequirement.java +++ b/src/main/java/sh/okx/rankup/requirements/requirement/AdvancementRequirement.java @@ -31,15 +31,16 @@ public class AdvancementRequirement extends Requirement { Advancement adv = advancementIterator.next(); String key = adv.getKey().getKey(); Pattern pattern = Pattern.compile(string.replace("*", ".*").replace("-", "")); - boolean positive = false; if (pattern.matcher(key).find()) { - positive = !string.startsWith("-"); + boolean positive = !string.startsWith("-"); + + AdvancementProgress progress = player.getAdvancementProgress(adv); + if (progress.isDone() == positive) { + return true; + } } - AdvancementProgress progress = player.getAdvancementProgress(adv); - if (progress.isDone() == positive) { - return true; - } + } } return false;