3.1.2 bugfixes (see long description)

- add messages in /rank and /rankup for when the configuration has a rankup to a non-existent rank.
- add invalid rankup message
- fix error for placeholders when prestiging is disabled
- add message for when a rank has no requirements
This commit is contained in:
okx-code
2018-10-03 15:43:55 +01:00
parent cad5280006
commit ae52d94fe8
9 changed files with 36 additions and 15 deletions
@@ -32,8 +32,14 @@ public class RankupCommand implements CommandExecutor {
Rankups rankups = plugin.getRankups();
Rank rank = rankups.getByPlayer(player);
Rank next = rankups.next(rank);
if (!plugin.checkRankup(player)) {
return true;
} else if(next == null) {
plugin.getLogger().severe("Rankup from " + rank.getName() + " to " + rank.getNext() +
" is defined but " + rank.getNext() + " does not exist.");
plugin.getMessage(Message.INVALID_RANKUP).failIfEmpty().send(player);
return true;
}
FileConfiguration config = plugin.getConfig();
@@ -52,11 +58,11 @@ public class RankupCommand implements CommandExecutor {
case "text":
confirming.put(player, System.currentTimeMillis());
plugin.replaceMoneyRequirements(plugin.getMessage(rank, Message.CONFIRMATION)
.replaceRanks(player, rank, rankups.next(rank)), player, rank)
.replaceRanks(player, rank, next), player, rank)
.send(player);
break;
case "gui":
Gui.of(player, rank, rankups.next(rank), plugin).open(player);
Gui.of(player, rank, next, plugin).open(player);
break;
case "none":
plugin.rankup(player);