Fix TODOs

Fixes non UTF8 filenames by not converting to `String` for no reason.

Also removes TODO for the fill-page feature, which already exists.
This commit is contained in:
Max Dexheimer
2026-01-22 15:32:59 +01:00
parent 828db8aed3
commit 577141e201
4 changed files with 4 additions and 9 deletions
+1 -4
View File
@@ -209,10 +209,6 @@ async fn inner_main() -> Result<(), WrappedErr> {
)
.map_err(|e| WrappedErr(format!("Can't watch the provided file: {e}").into()))?;
// TODO: Handle non-utf8 file names? Maybe by constructing a CString and passing that in to the
// mupdf stuff instead of a rust string?
let file_path = path.clone().into_os_string().to_string_lossy().to_string();
let mut window_size = window_size().map_err(|e| {
WrappedErr(format!("Can't get your current terminal window size: {e}").into())
})?;
@@ -266,6 +262,7 @@ async fn inner_main() -> Result<(), WrappedErr> {
.and_then(NonZeroUsize::new)
.map_or(PrerenderLimit::All, PrerenderLimit::Limited);
let file_path = path.clone();
std::thread::spawn(move || {
renderer::start_rendering(
&file_path,